From 4d2e91a10dd6b2b3a1ec25a26e2f64d9c4212fe9 Mon Sep 17 00:00:00 2001 From: Moses Nakamura Date: Mon, 9 May 2016 18:14:33 -0700 Subject: [PATCH] codec-http2: Stop leaking in header downgrader test Motivation: We're leaking requests in our Http2ServerDowngrader tests when we allocate a buffer using the local allocator. Modification: Release the request later when the request is constructed with the local allocator. Result: Less leaky tests. --- .../io/netty/handler/codec/http2/Http2ServerDowngraderTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java index e7ca6702e7..a3fbb05059 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java +++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java @@ -34,6 +34,7 @@ import io.netty.handler.codec.http.HttpResponseStatus; import io.netty.handler.codec.http.HttpVersion; import io.netty.handler.codec.http.LastHttpContent; import io.netty.util.CharsetUtil; +import io.netty.util.ReferenceCountUtil; import org.junit.Test; @@ -246,6 +247,7 @@ public class Http2ServerDowngraderTest { assertTrue(ch.writeInbound(new DefaultHttp2HeadersFrame(headers, true))); FullHttpRequest request = ch.readInbound(); + ReferenceCountUtil.releaseLater(request); assertThat(request.uri(), is("/")); assertThat(request.method(), is(HttpMethod.GET)); assertThat(request.protocolVersion(), is(HttpVersion.HTTP_1_1));