andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

+= won't let compile optimize String concats

Browse Source
This commit is contained in:
Stephane Landelle 2014-01-16 11:08:48 +01:00 committed by Norman Maurer
parent 75cb91ed0c
commit 4dc78c10ee
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java
View File

@ -559,14 +559,17 @@ public class HttpPostRequestEncoder implements ChunkedInput<HttpContent> {
.size() - 2); .size() - 2);
// remove past size // remove past size
globalBodySize -= pastAttribute.size(); globalBodySize -= pastAttribute.size();
String replacement = HttpPostBodyUtil.CONTENT_DISPOSITION + ": " + HttpPostBodyUtil.FORM_DATA StringBuilder replacement = new StringBuilder().append(HttpPostBodyUtil.CONTENT_DISPOSITION)
+ "; " + HttpPostBodyUtil.NAME + "=\"" + fileUpload.getName() + "\"\r\n"; .append(": ").append(HttpPostBodyUtil.FORM_DATA).append("; ").append(HttpPostBodyUtil.NAME)
replacement += HttpHeaders.Names.CONTENT_TYPE + ": " + HttpPostBodyUtil.MULTIPART_MIXED + "; " .append("=\"").append(fileUpload.getName()).append("\"\r\n");
+ HttpHeaders.Values.BOUNDARY + '=' + multipartMixedBoundary + "\r\n\r\n"; replacement.append(HttpHeaders.Names.CONTENT_TYPE).append(": ")
replacement += "--" + multipartMixedBoundary + "\r\n"; .append(HttpPostBodyUtil.MULTIPART_MIXED).append("; ").append(HttpHeaders.Values.BOUNDARY)
replacement += HttpPostBodyUtil.CONTENT_DISPOSITION + ": " + HttpPostBodyUtil.FILE + "; " .append('=').append(multipartMixedBoundary).append("\r\n\r\n");
+ HttpPostBodyUtil.FILENAME + "=\"" + fileUpload.getFilename() + "\"\r\n"; replacement.append("--").append(multipartMixedBoundary).append("\r\n");
pastAttribute.setValue(replacement, 1); replacement.append(HttpPostBodyUtil.CONTENT_DISPOSITION).append(": ").append(HttpPostBodyUtil.FILE)
.append("; ").append(HttpPostBodyUtil.FILENAME).append("=\"")
.append(fileUpload.getFilename()).append("\"\r\n");
pastAttribute.setValue(replacement.toString(), 1);
// update past size // update past size
globalBodySize += pastAttribute.size(); globalBodySize += pastAttribute.size();