Remove methods overridden but identical with the super implementation / Make constructors of abstract classes protected rather than non-sense public

AbstractWrappedByteBuf.capacity(int) should raise a UnsupportedOperationException rather than ReadOnlyBufferException.

buffer/src/main/java/io/netty/buffer/AbstractWrappedByteBuf.java

@@ -32,7 +32,7 @@ public abstract class AbstractWrappedByteBuf extends AbstractByteBuf implements
 
     @Override
     public WrappedByteBuf capacity(int newCapacity) {
-        throw new ReadOnlyBufferException();
+        throw new UnsupportedOperationException();
     }
 
     @Override

buffer/src/main/java/io/netty/buffer/DuplicatedByteBuf.java

@@ -108,11 +108,6 @@ public class DuplicatedByteBuf extends AbstractWrappedByteBuf {
         return buffer.getLong(index);
     }
 
-    @Override
-    public ByteBuf duplicate() {
-        return new DuplicatedByteBuf(this);
-    }
-
     @Override
     public ByteBuf copy(int index, int length) {
         return buffer.copy(index, length);

codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java

@@ -37,7 +37,7 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
     private boolean isRenamed;
     private FileChannel fileChannel;
 
-    public AbstractDiskHttpData(String name, Charset charset, long size) {
+    protected AbstractDiskHttpData(String name, Charset charset, long size) {
         super(name, charset, size);
     }
 

codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractHttpData.java

@@ -30,7 +30,7 @@ public abstract class AbstractHttpData implements HttpData {
     protected Charset charset = HttpConstants.DEFAULT_CHARSET;
     protected boolean completed;
 
-    public AbstractHttpData(String name, Charset charset, long size) {
+    protected AbstractHttpData(String name, Charset charset, long size) {
         if (name == null) {
             throw new NullPointerException("name");
         }

codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java

@@ -39,7 +39,7 @@ public abstract class AbstractMemoryHttpData extends AbstractHttpData {
     private int chunkPosition;
     protected boolean isRenamed;
 
-    public AbstractMemoryHttpData(String name, Charset charset, long size) {
+    protected AbstractMemoryHttpData(String name, Charset charset, long size) {
         super(name, charset, size);
     }
 

codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java

@@ -56,8 +56,8 @@ public abstract class WebSocketClientHandshaker {
      * @param maxFramePayloadLength
      *            Maximum length of a frame's payload
      */
-    public WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
-            Map<String, String> customHeaders, int maxFramePayloadLength) {
+    protected WebSocketClientHandshaker(URI webSocketUrl, WebSocketVersion version, String subprotocol,
+                                        Map<String, String> customHeaders, int maxFramePayloadLength) {
         this.webSocketUrl = webSocketUrl;
         this.version = version;
         expectedSubprotocol = subprotocol;

codec-http/src/main/java/io/netty/handler/codec/spdy/SpdyOrHttpChooser.java

@@ -50,7 +50,7 @@ public abstract class SpdyOrHttpChooser extends ChannelHandlerAdapter implements
     private final int maxSpdyContentLength;
     private final int maxHttpContentLength;
 
-    public SpdyOrHttpChooser(int maxSpdyContentLength, int maxHttpContentLength) {
+    protected SpdyOrHttpChooser(int maxSpdyContentLength, int maxHttpContentLength) {
         this.maxSpdyContentLength = maxSpdyContentLength;
         this.maxHttpContentLength = maxHttpContentLength;
     }