From 4e3a4130470626fbaa0bad712001887b0e4ad8f7 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Fri, 18 Mar 2016 12:58:46 +0100 Subject: [PATCH] Correctly handle UpgradeEvent.release(decrement). Motivation: We missed to pass the decrement value to the wrapped FullHttpRequest and so missed to decrement the reference count in the correct way. Modifications: Correctly pass the decrement value to the wrapped request. Result: UpgradeEvent.release(decrement) works as expected. --- .../io/netty/handler/codec/http/HttpServerUpgradeHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java index 0d513ef9bc..0185d45aa1 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java @@ -158,7 +158,7 @@ public class HttpServerUpgradeHandler extends HttpObjectAggregator { @Override public boolean release(int decrement) { - return upgradeRequest.release(); + return upgradeRequest.release(decrement); } @Override