andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Less noisy logging in DnsServerAddressStreamProviders (#11031)

Browse Source 
Motivation:

It is not uncommon to run Netty on OS X without the specific
`MacOSDnsServerAddressStreamProvider`. The current log message is too
verbose because it prints a full stack trace on the console while a
simple logging message would have been enough.

Modifications:

- Print a `WARN` message when `MacOSDnsServerAddressStreamProvider`
class is not found;
- Print a `ERROR` message with a stack trace when the class was found
but could not be loaded due to some other reasons;

Result:

Less noise in logs.
This commit is contained in:
Idel Pivnitskiy 2021-02-23 02:03:07 -08:00 committed by GitHub
parent a0b1984c50
commit 5158e3976d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java
View File

@ -66,10 +66,12 @@ public final class DnsServerAddressStreamProviders {
} else { } else {
throw (Throwable) maybeProvider; throw (Throwable) maybeProvider;
} }
} catch (ClassNotFoundException cause) {
LOGGER.warn("Can not find {} in the classpath, fallback to system defaults. This may result in "
+ "incorrect DNS resolutions on MacOS.", MACOS_PROVIDER_CLASS_NAME);
} catch (Throwable cause) { } catch (Throwable cause) {
LOGGER.warn( LOGGER.error("Unable to load {}, fallback to system defaults. This may result in "
"Unable to load {}, fallback to system defaults. {}", MACOS_PROVIDER_CLASS_NAME, + "incorrect DNS resolutions on MacOS.", MACOS_PROVIDER_CLASS_NAME, cause);
"This may result in incorrect DNS resolutions on MacOS.", cause);
constructor = null; constructor = null;
} }
} }