andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix StackOverflowError in ChunkedWriteHandler; issue #620

Browse Source
This commit is contained in:
Lukasz Osipiuk 2012-09-21 14:56:31 +02:00
parent a7d205075b
commit 5362842548
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
View File

@ -186,6 +186,7 @@ public class ChunkedWriteHandler
private void flush(ChannelHandlerContext ctx, boolean fireNow) throws Exception { private void flush(ChannelHandlerContext ctx, boolean fireNow) throws Exception {
boolean acquired = false; boolean acquired = false;
final Channel channel = ctx.getChannel(); final Channel channel = ctx.getChannel();
boolean suspend = false;
// use CAS to see if the have flush already running, if so we don't need to take futher actions // use CAS to see if the have flush already running, if so we don't need to take futher actions
if (acquired = flush.compareAndSet(false, true)) { if (acquired = flush.compareAndSet(false, true)) {
@ -216,7 +217,6 @@ public class ChunkedWriteHandler
final ChunkedInput chunks = (ChunkedInput) m; final ChunkedInput chunks = (ChunkedInput) m;
Object chunk; Object chunk;
boolean endOfInput; boolean endOfInput;
boolean suspend;
try { try {
chunk = chunks.nextChunk(); chunk = chunks.nextChunk();
endOfInput = chunks.isEndOfInput(); endOfInput = chunks.isEndOfInput();
@ -297,7 +297,7 @@ public class ChunkedWriteHandler
} }
if (acquired && (!channel.isConnected() || channel.isWritable() && !queue.isEmpty())) { if (acquired && (!channel.isConnected() || channel.isWritable() && !queue.isEmpty() && !suspend)) {
flush(ctx, fireNow); flush(ctx, fireNow);
} }
} }