andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix race-condition which could lead to a NPE or Exception while register a Channel with a Worker. See #469

Browse Source
This commit is contained in:
norman 2012-07-23 09:25:26 +02:00
parent c059d13108
commit 54ad935ec5
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorker.java
View File

@ -143,14 +143,17 @@ abstract class AbstractNioWorker implements Worker {
assert offered; assert offered;
if (wakenUp.compareAndSet(false, true)) { if (wakenUp.compareAndSet(false, true)) {
// wake up the selector to speed things synchronized (startStopLock) {
selector = this.selector; // wake up the selector to speed things
selector = this.selector;
// Check if the selector is not null to prevent NPE if selector was // Check if the selector is not null to prevent NPE if selector was
// set to null from another thread. See #469 // set to null from another thread. See #469
if (selector != null) { if (selector != null) {
selector.wakeup(); selector.wakeup();
}
} }
} }
} }