andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Also clear the authoritativeDnsServerCache when closing the Channel. (#8174)

Browse Source 
Motivation:

At the moment we only clear the resolveCache when the Channel is closed. We should also do the same for the authoritativeDnsServerCache.

Modifications:

Add authoritativeDnsServerCache.clear() to the Channel closeFuture.

Result:

Correctly clear all caches.
This commit is contained in:
Norman Maurer 2018-08-06 08:31:17 +02:00 committed by GitHub
parent 2c13f71c73
commit 55fec94592
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
View File

@ -219,7 +219,7 @@ public class DnsNameResolver extends InetNameResolver {
EventLoop eventLoop, EventLoop eventLoop,
ChannelFactory<? extends DatagramChannel> channelFactory, ChannelFactory<? extends DatagramChannel> channelFactory,
final DnsCache resolveCache, final DnsCache resolveCache,
DnsCache authoritativeDnsServerCache, final DnsCache authoritativeDnsServerCache,
DnsQueryLifecycleObserverFactory dnsQueryLifecycleObserverFactory, DnsQueryLifecycleObserverFactory dnsQueryLifecycleObserverFactory,
long queryTimeoutMillis, long queryTimeoutMillis,
ResolvedAddressTypes resolvedAddressTypes, ResolvedAddressTypes resolvedAddressTypes,
@ -306,8 +306,9 @@ public class DnsNameResolver extends InetNameResolver {
ch.closeFuture().addListener(new ChannelFutureListener() { ch.closeFuture().addListener(new ChannelFutureListener() {
@Override @Override
public void operationComplete(ChannelFuture future) throws Exception { public void operationComplete(ChannelFuture future) {
resolveCache.clear(); resolveCache.clear();
authoritativeDnsServerCache.clear();
} }
}); });
} }