andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix testStreamIsNotCreatedIfParentConnectionIsClosedConcurrently test (#10472)

Browse Source 
Motivation:

testStreamIsNotCreatedIfParentConnectionIsClosedConcurrently() made some assumptions about sequencing which may not be true all the time and racy.

Modifications:

Fix the testcase so its not racy anymore

Result:

Fix build failure on master branch
This commit is contained in:
Norman Maurer 2020-08-12 07:09:00 +02:00 committed by GitHub
parent adcffb6260
commit 58654fff7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamChannelBootstrapTest.java
View File

@ -95,28 +95,13 @@ public class Http2StreamChannelBootstrapTest {
clientChannel = cb.connect(serverAddress).sync().channel();
assertTrue(serverChannelLatch.await(3, SECONDS));
final CountDownLatch closeLatch = new CountDownLatch(1);
final Channel clientChannelToClose = clientChannel;
group.execute(new Runnable() {
@Override
public void run() {
try {
closeLatch.await();
clientChannelToClose.close().syncUninterruptibly();
} catch (InterruptedException e) {
logger.error(e);
}
}
});
Http2StreamChannelBootstrap bootstrap = new Http2StreamChannelBootstrap(clientChannel);
Promise<Http2StreamChannel> promise = clientChannel.eventLoop().newPromise();
clientChannel.close().sync();
bootstrap.open(promise);
assertThat(promise.isDone(), is(false));
closeLatch.countDown();
exceptionRule.expect(ExecutionException.class);
exceptionRule.expectCause(IsInstanceOf.<Throwable>instanceOf(ClosedChannelException.class));
exceptionRule.expectCause(IsInstanceOf.instanceOf(ClosedChannelException.class));
promise.get(3, SECONDS);
} finally {
safeClose(clientChannel);