andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use standard syntax for logging HTTP/2 stream ID.

Browse Source 
Motivation:

When looking through the logs for entries pertaining to a specific stream, it's difficult because header entries use the syntax "streamId:<id>" but all other entries use "streamId=<id>". We should make all of the entries consistent.

Modifications:

Changed header entries to use "streamId=<id>" to match the other entries.

Result:

Easier HTTP/2 log navigation.
This commit is contained in:
nmittler 2015-07-28 09:43:50 -07:00
parent 348082c433
commit 595fb88839
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java
View File

@ -68,7 +68,7 @@ public class Http2FrameLogger extends ChannelHandlerAdapter {
public void logHeaders(Direction direction, int streamId, Http2Headers headers, int padding, public void logHeaders(Direction direction, int streamId, Http2Headers headers, int padding,
boolean endStream) { boolean endStream) {
if (enabled()) { if (enabled()) {
log(direction, "HEADERS: streamId:%d, headers=%s, padding=%d, endStream=%b", log(direction, "HEADERS: streamId=%d, headers=%s, padding=%d, endStream=%b",
streamId, headers, padding, endStream); streamId, headers, padding, endStream);
} }
} }
@ -77,7 +77,7 @@ public class Http2FrameLogger extends ChannelHandlerAdapter {
int streamDependency, short weight, boolean exclusive, int padding, boolean endStream) { int streamDependency, short weight, boolean exclusive, int padding, boolean endStream) {
if (enabled()) { if (enabled()) {
log(direction, log(direction,
"HEADERS: streamId:%d, headers=%s, streamDependency=%d, weight=%d, exclusive=%b, " "HEADERS: streamId=%d, headers=%s, streamDependency=%d, weight=%d, exclusive=%b, "
+ "padding=%d, endStream=%b", streamId, headers, + "padding=%d, endStream=%b", streamId, headers,
streamDependency, weight, exclusive, padding, endStream); streamDependency, weight, exclusive, padding, endStream);
} }