andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid casting numbers to narrower types (#10645)

Browse Source 
Motivation:

Avoid implicit conversions to narrower types in
AbstractMemoryHttpData and Bzip2HuffmanStageEncoder classes
reported by LGTM.

Modifications:

Updated the classes to avoid implicit casting to narrower types.
It doesn't look like that an integer overflow is possible there,
therefore no checks for overflows were added.

Result:

No warnings about implicit conversions to narrower types.
This commit is contained in:
Artem Smotrakov 2020-10-12 09:33:47 +02:00 committed by GitHub
parent 00f21845f8
commit 5b55ee434b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java
View File

@ -237,7 +237,7 @@ public abstract class AbstractMemoryHttpData extends AbstractHttpData {
return true; return true;
} }
int length = byteBuf.readableBytes(); int length = byteBuf.readableBytes();
int written = 0; long written = 0;
RandomAccessFile accessFile = new RandomAccessFile(dest, "rw"); RandomAccessFile accessFile = new RandomAccessFile(dest, "rw");
try { try {
FileChannel fileChannel = accessFile.getChannel(); FileChannel fileChannel = accessFile.getChannel();

2
codec/src/main/java/io/netty/handler/codec/compression/Bzip2HuffmanStageEncoder.java
View File

@ -219,7 +219,7 @@ final class Bzip2HuffmanStageEncoder {
final int groupEnd = Math.min(groupStart + HUFFMAN_GROUP_RUN_LENGTH, mtfLength) - 1; final int groupEnd = Math.min(groupStart + HUFFMAN_GROUP_RUN_LENGTH, mtfLength) - 1;
// Calculate the cost of this group when encoded by each table // Calculate the cost of this group when encoded by each table
short[] cost = new short[totalTables]; int[] cost = new int[totalTables];
for (int i = groupStart; i <= groupEnd; i++) { for (int i = groupStart; i <= groupEnd; i++) {
final int value = mtfBlock[i]; final int value = mtfBlock[i];
for (int j = 0; j < totalTables; j++) { for (int j = 0; j < totalTables; j++) {