From 5b5c38b47cc8bc84150104bf782ccab5c38be15a Mon Sep 17 00:00:00 2001
From: Stephane Landelle <slandelle@excilys.com>
Date: Wed, 21 Jan 2015 15:02:21 +0100
Subject: [PATCH] Drop first flag that's no longer used

Motivation:

Pull request for RFC6265 support had some unused flag first in ClientCookieDecoder.

Modification:

Remove unused flag first.

Result:

Cleaner code.
---
 .../netty/handler/codec/http/ClientCookieDecoder.java  | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/ClientCookieDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/ClientCookieDecoder.java
index c4b0025837..d2e57dbed5 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/ClientCookieDecoder.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/ClientCookieDecoder.java
@@ -73,7 +73,6 @@ public final class ClientCookieDecoder {
             int newNameStart = i;
             int newNameEnd = i;
             String value, rawValue;
-            boolean first = true;
 
             if (i == headerLen) {
                 value = rawValue = null;
@@ -85,7 +84,6 @@ public final class ClientCookieDecoder {
                         // NAME; (no value till ';')
                         newNameEnd = i;
                         value = rawValue = null;
-                        first = false;
                         break keyValLoop;
                     } else if (curChar == '=') {
                         // NAME=VALUE
@@ -94,7 +92,6 @@ public final class ClientCookieDecoder {
                         if (i == headerLen) {
                             // NAME= (empty value, i.e. nothing after '=')
                             value = rawValue = "";
-                            first = false;
                             break keyValLoop;
                         }
 
@@ -115,8 +112,7 @@ public final class ClientCookieDecoder {
                                     value = newValueBuf.toString();
                                     // only need to compute raw value for cookie
                                     // value which is in first position
-                                    rawValue = first ? header.substring(rawValueStart, rawValueEnd) : null;
-                                    first = false;
+                                    rawValue = header.substring(rawValueStart, rawValueEnd);
                                     break keyValLoop;
                                 }
                                 if (hadBackslash) {
@@ -137,8 +133,7 @@ public final class ClientCookieDecoder {
                                         // only need to compute raw value for
                                         // cookie value which is in first
                                         // position
-                                        rawValue = first ? header.substring(rawValueStart, rawValueEnd) : null;
-                                        first = false;
+                                        rawValue = header.substring(rawValueStart, rawValueEnd);
                                         break keyValLoop;
                                     }
                                     newValueBuf.append(c);
@@ -166,7 +161,6 @@ public final class ClientCookieDecoder {
                     if (i == headerLen) {
                         // NAME (no value till the end of string)
                         newNameEnd = i;
-                        first = false;
                         value = rawValue = null;
                         break;
                     }