andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix SocketException in NioSocketChannelUnsafe.closeExecutor()

Browse Source 
Related: #3464

Motivation:

When a connection attempt is failed,
NioSocketChannelUnsafe.closeExecutor() triggers a SocketException,
suppressing the channelUnregistered() event.

Modification:

Do not attempt to get SO_LINGER value when a socket is not open yet.

Result:

One less bug
This commit is contained in:
Trustin Lee 2015-03-05 15:14:59 +09:00
parent 6880e27ce9
commit 5d15e18cbf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java
View File

@ -332,7 +332,7 @@ public class NioSocketChannel extends AbstractNioByteChannel implements io.netty
private final class NioSocketChannelUnsafe extends NioByteUnsafe { private final class NioSocketChannelUnsafe extends NioByteUnsafe {
@Override @Override
protected Executor closeExecutor() { protected Executor closeExecutor() {
if (config().getSoLinger() > 0) { if (javaChannel().isOpen() && config().getSoLinger() > 0) {
return GlobalEventExecutor.INSTANCE; return GlobalEventExecutor.INSTANCE;
} }
return null; return null;