Add missing final modifiers

This commit is contained in:
Trustin Lee 2012-11-10 02:19:39 +09:00
parent 6453b71ab0
commit 5d1690dfa7
7 changed files with 9 additions and 9 deletions

View File

@ -31,7 +31,7 @@ public final class WebSocketSslServerSslContext {
private static final InternalLogger logger = InternalLoggerFactory.getInstance(WebSocketSslServerSslContext.class); private static final InternalLogger logger = InternalLoggerFactory.getInstance(WebSocketSslServerSslContext.class);
private static final String PROTOCOL = "TLS"; private static final String PROTOCOL = "TLS";
private SSLContext _serverContext; private final SSLContext _serverContext;
/** /**
* Returns the singleton instance for this class * Returns the singleton instance for this class

View File

@ -15,7 +15,7 @@
*/ */
package org.jboss.netty.handler.stream; package org.jboss.netty.handler.stream;
import static org.jboss.netty.buffer.ChannelBuffers.*; import org.jboss.netty.channel.FileRegion;
import java.io.File; import java.io.File;
import java.io.FileInputStream; import java.io.FileInputStream;
@ -23,7 +23,7 @@ import java.io.IOException;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.nio.channels.FileChannel; import java.nio.channels.FileChannel;
import org.jboss.netty.channel.FileRegion; import static org.jboss.netty.buffer.ChannelBuffers.*;
/** /**
* A {@link ChunkedInput} that fetches data from a file chunk by chunk using * A {@link ChunkedInput} that fetches data from a file chunk by chunk using
@ -36,7 +36,7 @@ import org.jboss.netty.channel.FileRegion;
public class ChunkedNioFile implements ChunkedInput { public class ChunkedNioFile implements ChunkedInput {
private final FileChannel in; private final FileChannel in;
private long startOffset; private final long startOffset;
private final long endOffset; private final long endOffset;
private final int chunkSize; private final int chunkSize;
private long offset; private long offset;

View File

@ -28,7 +28,7 @@ import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
public class LocalAddressTest { public class LocalAddressTest {
private static String LOCAL_ADDR_ID = "test.id"; private static final String LOCAL_ADDR_ID = "test.id";
@Test @Test
public void localConnectOK() public void localConnectOK()

View File

@ -159,7 +159,7 @@ public class WebSocketServerProtocolHandlerTest {
private static class HttpResponseInterceptor extends HttpResponseEncoder { private static class HttpResponseInterceptor extends HttpResponseEncoder {
private Queue<HttpResponse> responses = new LinkedList<HttpResponse>(); private final Queue<HttpResponse> responses = new LinkedList<HttpResponse>();
@Override @Override
protected Object encode(ChannelHandlerContext ctx, Channel channel, Object msg) throws Exception { protected Object encode(ChannelHandlerContext ctx, Channel channel, Object msg) throws Exception {

View File

@ -72,7 +72,7 @@ public class ReplayingDecoderBufferTest {
} }
private class ReplayDecoderImpl extends ReplayingDecoder<VoidEnum> { private class ReplayDecoderImpl extends ReplayingDecoder<VoidEnum> {
private ChannelBuffer internal = ChannelBuffers.copiedBuffer("TestBuffer", CharsetUtil.ISO_8859_1); private final ChannelBuffer internal = ChannelBuffers.copiedBuffer("TestBuffer", CharsetUtil.ISO_8859_1);
@Override @Override
protected ChannelBuffer internalBuffer() { protected ChannelBuffer internalBuffer() {

View File

@ -75,7 +75,7 @@ public class ExecutionHandlerTest {
private final CountDownLatch latch; private final CountDownLatch latch;
private final ExecutionHandler handler; private final ExecutionHandler handler;
private Channel channel; private final Channel channel;
public TestChannelHandlerContext(Channel channel, ExecutionHandler handler, CountDownLatch latch) { public TestChannelHandlerContext(Channel channel, ExecutionHandler handler, CountDownLatch latch) {
this.latch = latch; this.latch = latch;

View File

@ -99,7 +99,7 @@ public class ChunkedWriteHandlerTest {
ChunkedInput input = new ChunkedInput() { ChunkedInput input = new ChunkedInput() {
private boolean done; private boolean done;
private ChannelBuffer buffer = ChannelBuffers.copiedBuffer("Test", CharsetUtil.ISO_8859_1); private final ChannelBuffer buffer = ChannelBuffers.copiedBuffer("Test", CharsetUtil.ISO_8859_1);
public Object nextChunk() throws Exception { public Object nextChunk() throws Exception {
done = true; done = true;