andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1982] Limit the usage of ThreadLocal.get() for performance reasons

Browse Source
This commit is contained in:
Norman Maurer 2013-11-14 09:33:40 +01:00
parent 8bfbf77b58
commit 5de4b23c7a
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
View File

@ -105,13 +105,6 @@ public abstract class HttpObjectDecoder extends ReplayingDecoder<HttpObjectDecod
protected StringBuilder initialValue() { protected StringBuilder initialValue() {
return new StringBuilder(512); return new StringBuilder(512);
} }
@Override
public StringBuilder get() {
StringBuilder builder = super.get();
builder.setLength(0);
return builder;
}
}; };
private final int maxInitialLineLength; private final int maxInitialLineLength;
@ -125,6 +118,7 @@ public abstract class HttpObjectDecoder extends ReplayingDecoder<HttpObjectDecod
private long chunkSize; private long chunkSize;
private int headerSize; private int headerSize;
private int contentRead; private int contentRead;
private StringBuilder sb;
/** /**
* The internal state of {@link HttpObjectDecoder}. * The internal state of {@link HttpObjectDecoder}.
@ -673,7 +667,7 @@ public abstract class HttpObjectDecoder extends ReplayingDecoder<HttpObjectDecod
} }
private StringBuilder readHeader(ByteBuf buffer) { private StringBuilder readHeader(ByteBuf buffer) {
StringBuilder sb = BUILDERS.get(); StringBuilder sb = builder();
int headerSize = this.headerSize; int headerSize = this.headerSize;
loop: loop:
@ -728,8 +722,8 @@ public abstract class HttpObjectDecoder extends ReplayingDecoder<HttpObjectDecod
return Integer.parseInt(hex, 16); return Integer.parseInt(hex, 16);
} }
private static StringBuilder readLine(ByteBuf buffer, int maxLineLength) { private StringBuilder readLine(ByteBuf buffer, int maxLineLength) {
StringBuilder sb = BUILDERS.get(); StringBuilder sb = builder();
int lineLength = 0; int lineLength = 0;
while (true) { while (true) {
byte nextByte = buffer.readByte(); byte nextByte = buffer.readByte();
@ -846,4 +840,14 @@ public abstract class HttpObjectDecoder extends ReplayingDecoder<HttpObjectDecod
} }
return result; return result;
} }
private StringBuilder builder() {
if (sb == null) {
// Obtain the StringBuilder from the ThreadLocal and store it for later usage.
// This minimize the ThreadLocal.get() operations a lot and so eliminate some overhead
sb = BUILDERS.get();
}
sb.setLength(0);
return sb;
}
} }