From 5deaf94bfef0562bc5bbd7983d58d8f58d0bd3be Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Wed, 17 Mar 2021 12:18:50 -0700 Subject: [PATCH] Github Actions dawidd6/action-download-artifact set workflow_conclusion (#11096) Motivation: Newer versions of dawidd6/action-download-artifact changed the default workflow_conclusion from "completed" to "completed, success" which can result in download failures if the associated job fails, which is expected when tests fail. Modifications: - Explicitly set the workflow_conclusion to "completed" Result: Test failures which result in build failures will still download test data and generate reports after updating dawidd6/action-download-artifact. --- .github/workflows/ci-pr-reports.yml | 1 + .github/workflows/codeql-analysis.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-pr-reports.yml b/.github/workflows/ci-pr-reports.yml index b5e865b4fd..db189af5c5 100644 --- a/.github/workflows/ci-pr-reports.yml +++ b/.github/workflows/ci-pr-reports.yml @@ -19,6 +19,7 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} workflow: ${{ github.event.workflow_run.workflow_id }} + workflow_conclusion: completed commit: ${{ github.event.workflow_run.head_commit.id }} # File location set in ci-pr.yml and must be coordinated. name: test-results-${{ matrix.setup }} diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 268b6d5dd2..ad96e0ff57 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -58,7 +58,7 @@ jobs: with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. - # By default, queries listed here will override any specified in a config file. + # By default, queries listed here will override any specified in a config file. # Prefix the list here with "+" to use these queries and those in the config file. # queries: ./path/to/local/query, your-org/your-repo/queries@main