From 5e0ee6c09522ae573ef03b77dbd609f3db4d15b6 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Mon, 4 May 2015 12:05:59 +0900 Subject: [PATCH] Fix missing ResourceLeak.close() in AbstractDnsMessage Motivation: ResourceLeak.close() must be called when a reference-counted resource is deallocated, but AbstractDnsMessage.deallocate() forgot to call it. Modifications: Call ResourceLeak.close() for the tracked AbstractDnsMessage instances Result: Fix the false resource leak warnings --- .../java/io/netty/handler/codec/dns/AbstractDnsMessage.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java b/codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java index 40b5aa8f53..31232cff47 100644 --- a/codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java +++ b/codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java @@ -375,6 +375,11 @@ public abstract class AbstractDnsMessage extends AbstractReferenceCounted implem @Override protected void deallocate() { clear(); + + final ResourceLeak leak = this.leak; + if (leak != null) { + leak.close(); + } } @Override