andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Also remove the id from the DnsQueryContextManager if query fails due parent Channel activation error.

Browse Source 
Motivation:

Whenever we fail the query we should also remove the id from the DnsQueryContextManager.

Modifications:

Remove the id from the DnsQueryContextManager if we fail the query because the channel failed to become active.

Result:

More correct code.
This commit is contained in:
Norman Maurer 2018-06-25 21:14:37 +02:00
parent 00afb19d7a
commit 5e42e758be
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java
View File

@ -115,10 +115,13 @@ final class DnsQueryContext {
} else { } else {
parent.channelFuture.addListener(new GenericFutureListener<Future<? super Channel>>() { parent.channelFuture.addListener(new GenericFutureListener<Future<? super Channel>>() {
@Override @Override
public void operationComplete(Future<? super Channel> future) throws Exception { public void operationComplete(Future<? super Channel> future) {
if (future.isSuccess()) { if (future.isSuccess()) {
writeQuery(query, writePromise); writeQuery(query, writePromise);
} else { } else {
// Remove the id from the manager as we fail the query.
parent.queryContextManager.remove(nameServerAddr(), id);
Throwable cause = future.cause(); Throwable cause = future.cause();
promise.tryFailure(cause); promise.tryFailure(cause);
writePromise.setFailure(cause); writePromise.setFailure(cause);