From 5e79d57b7d6180fe5aadaa97fd06d5fd6980f6f9 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Thu, 6 Dec 2018 20:43:40 +0100 Subject: [PATCH] Skip test on windows as the semantics we expect are only true on Linux / Unix / BSD / MacOS (#8629) Motivation: In the test we assume some semantics on how RST is done that are not true for Windows so we should skip it. Modifications: Skip test when on windows. Result: Be able to run testsuite on windows. Fixes https://github.com/netty/netty/issues/8571. --- .../testsuite/transport/socket/SocketHalfClosedTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java index cd03ac3c9b..2680810a91 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java +++ b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java @@ -34,6 +34,8 @@ import io.netty.channel.socket.ChannelInputShutdownReadComplete; import io.netty.channel.socket.ChannelOutputShutdownEvent; import io.netty.channel.socket.DuplexChannel; import io.netty.util.UncheckedBooleanSupplier; +import io.netty.util.internal.PlatformDependent; +import org.junit.Assume; import org.junit.Test; import java.util.concurrent.CountDownLatch; @@ -229,6 +231,8 @@ public class SocketHalfClosedTest extends AbstractSocketTest { @Test public void testAutoCloseFalseDoesShutdownOutput() throws Throwable { + // This test only works on Linux / BSD / MacOS as we assume some semantics that are not true for Windows. + Assume.assumeFalse(PlatformDependent.isWindows()); run(); }