andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't create a new ParserImpl on each parser() call (#11255)

Browse Source 
Motivation:

ParserImpl is stateless and so we can use the same instance multiple times

Modifications:

- Make constructor private
- Return the same instance all the time

Result:

Less object creation
This commit is contained in:
Norman Maurer 2021-05-14 15:19:04 +02:00
parent 747a686cd7
commit 605290f821
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
resolver/src/main/java/io/netty/resolver/HostsFileEntriesProvider.java
View File

@ -120,7 +120,7 @@ public final class HostsFileEntriesProvider {
* @return a new {@link HostsFileEntriesProvider.Parser} * @return a new {@link HostsFileEntriesProvider.Parser}
*/ */
public static Parser parser() { public static Parser parser() {
return new ParserImpl(); return ParserImpl.INSTANCE;
} }
static final HostsFileEntriesProvider EMPTY = static final HostsFileEntriesProvider EMPTY =
@ -164,6 +164,12 @@ public final class HostsFileEntriesProvider {
private static final InternalLogger logger = InternalLoggerFactory.getInstance(Parser.class); private static final InternalLogger logger = InternalLoggerFactory.getInstance(Parser.class);
static final ParserImpl INSTANCE = new ParserImpl();
private ParserImpl() {
// singleton
}
@Override @Override
public HostsFileEntriesProvider parse() throws IOException { public HostsFileEntriesProvider parse() throws IOException {
return parse(locateHostsFile(), Charset.defaultCharset()); return parse(locateHostsFile(), Charset.defaultCharset());