andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not use finally to propagate events in AbstractRemoteAddressFilter

Browse Source 
Motivation:

We don't really need to propagate an event when handling the event fails.

Modifications:

Do not use finally block in AbstractRemoteAddressFilter

Result:

AbstractRemoteaddressFilter does not forward an event in case of failure.
This commit is contained in:
Trustin Lee 2014-03-12 16:17:40 +09:00
parent fddbde7df2
commit 614dc72b56
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
handler/src/main/java/io/netty/handler/ipfilter/AbstractRemoteAddressFilter.java
View File

@ -39,20 +39,15 @@ public abstract class AbstractRemoteAddressFilter<T extends SocketAddress> exten
@Override @Override
public void channelRegistered(ChannelHandlerContext ctx) throws Exception { public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
try {
handleNewChannel(ctx); handleNewChannel(ctx);
} finally {
ctx.fireChannelRegistered(); ctx.fireChannelRegistered();
} }
}
@Override @Override
public void channelActive(ChannelHandlerContext ctx) throws Exception { public void channelActive(ChannelHandlerContext ctx) throws Exception {
try {
if (!handleNewChannel(ctx)) { if (!handleNewChannel(ctx)) {
throw new IllegalStateException("cannot determine to accept or reject a channel: " + ctx.channel()); throw new IllegalStateException("cannot determine to accept or reject a channel: " + ctx.channel());
} } else {
} finally {
ctx.fireChannelActive(); ctx.fireChannelActive();
} }
} }