andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1656] Fix IndexOutOfBoundsException in MessageToMessageException

Browse Source
This commit is contained in:
Norman Maurer 2013-07-26 11:46:26 +02:00
parent 5f363e8ade
commit 6278d88d2f
2 changed files with 45 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java
View File

@ -108,10 +108,12 @@ public abstract class MessageToMessageEncoder<I> extends ChannelOutboundHandlerA
} finally {
if (out != null) {
final int sizeMinusOne = out.size() - 1;
for (int i = 0; i < sizeMinusOne; i ++) {
ctx.write(out.get(i));
if (sizeMinusOne >= 0) {
for (int i = 0; i < sizeMinusOne; i ++) {
ctx.write(out.get(i));
}
ctx.write(out.get(sizeMinusOne), promise);
}
ctx.write(out.get(sizeMinusOne), promise);
out.recycle();
}
}

40
codec/src/test/java/io/netty/handler/codec/MessageToMessageEncoderTest.java Normal file
View File

@ -0,0 +1,40 @@
/*
* Copyright 2013 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.handler.codec;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.embedded.EmbeddedChannel;
import org.junit.Test;
import java.util.List;
public class MessageToMessageEncoderTest {
/**
* Test-case for https://github.com/netty/netty/issues/1656
*/
@Test(expected = EncoderException.class)
public void testException() {
EmbeddedChannel channel = new EmbeddedChannel(new MessageToMessageEncoder<Object>() {
@Override
protected void encode(ChannelHandlerContext ctx, Object msg, List<Object> out) throws Exception {
throw new Exception();
}
});
channel.writeOutbound(new Object());
}
}