andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve Http2FrameCodecBuilder usability (#11195)

Browse Source 
__Motivation__

 `Http2FrameCodecBuilder` constructor calls `server()` internally which disallows using certain methods on the builder later. Additionally, the constructor is package private which limits extension of the `Builder` as well as usage outside the available `forClient()` and `forServer()` static methods.

 __Modification__

 - Introduce a `public` no-arg constructor to `Http2FrameCodecBuilder`.

 __Result__

 `Http2FrameCodecBuilder` can now be used to create the codec with `Http2Connection` or `Http2ConnectionDecoder` and `Http2ConnectionEncoder` which was earlier not possible due to implicit call to `server()` by the `Http2FrameCodecBuilder` constructor.
This commit is contained in:
Nitesh Kant 2021-04-29 01:26:44 -07:00 committed by GitHub
parent d0fea48604
commit 63352b135a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodecBuilder.java
View File

@ -29,6 +29,9 @@ public class Http2FrameCodecBuilder extends
private Http2FrameWriter frameWriter; private Http2FrameWriter frameWriter;
public Http2FrameCodecBuilder() {
}
Http2FrameCodecBuilder(boolean server) { Http2FrameCodecBuilder(boolean server) {
server(server); server(server);
// For backwards compatibility we should disable to timeout by default at this layer. // For backwards compatibility we should disable to timeout by default at this layer.