andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#861] Let SctpMessageCompletionHandler fire inboundMessageBufferUpdated() only if needed

Browse Source
This commit is contained in:
Norman Maurer 2012-12-27 23:08:54 +01:00
parent 88838413c7
commit 64351ad7d6
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
codec/src/main/java/io/netty/handler/codec/sctp/SctpMessageCompletionHandler.java
View File

@ -19,14 +19,36 @@ package io.netty.handler.codec.sctp;
import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled; import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelInboundMessageHandler;
import io.netty.channel.ChannelInboundMessageHandlerAdapter; import io.netty.channel.ChannelInboundMessageHandlerAdapter;
import io.netty.channel.socket.SctpMessage; import io.netty.channel.socket.SctpMessage;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
/**
* {@link ChannelInboundMessageHandlerAdapter} which will take care of handle fragemented {@link SctpMessage}s, so
* only <strong>complete</strong> {@link SctpMessage}s will be forwarded to the next
* {@link ChannelInboundMessageHandler}.
*/
public class SctpMessageCompletionHandler extends ChannelInboundMessageHandlerAdapter<SctpMessage> { public class SctpMessageCompletionHandler extends ChannelInboundMessageHandlerAdapter<SctpMessage> {
private final Map<Integer, ByteBuf> fragments = new HashMap<Integer, ByteBuf>(); private final Map<Integer, ByteBuf> fragments = new HashMap<Integer, ByteBuf>();
private boolean assembled;
@Override
protected boolean beginMessageReceived(ChannelHandlerContext ctx) throws Exception {
assembled = false;
return super.beginMessageReceived(ctx);
}
@Override
protected void endMessageReceived(ChannelHandlerContext ctx) throws Exception {
if (assembled) {
assembled = false;
ctx.fireInboundBufferUpdated();
}
super.endMessageReceived(ctx);
}
@Override @Override
protected void messageReceived(ChannelHandlerContext ctx, SctpMessage msg) throws Exception { protected void messageReceived(ChannelHandlerContext ctx, SctpMessage msg) throws Exception {
@ -46,7 +68,7 @@ public class SctpMessageCompletionHandler extends ChannelInboundMessageHandlerAd
if (isComplete && !frag.readable()) { if (isComplete && !frag.readable()) {
//data chunk is not fragmented //data chunk is not fragmented
fireAssembledMessage(ctx, msg); handleAssembledMessage(ctx, msg);
} else if (!isComplete && frag.readable()) { } else if (!isComplete && frag.readable()) {
//more message to complete //more message to complete
fragments.put(streamIdentifier, Unpooled.wrappedBuffer(frag, byteBuf)); fragments.put(streamIdentifier, Unpooled.wrappedBuffer(frag, byteBuf));
@ -57,15 +79,15 @@ public class SctpMessageCompletionHandler extends ChannelInboundMessageHandlerAd
protocolIdentifier, protocolIdentifier,
streamIdentifier, streamIdentifier,
Unpooled.wrappedBuffer(frag, byteBuf)); Unpooled.wrappedBuffer(frag, byteBuf));
fireAssembledMessage(ctx, assembledMsg); handleAssembledMessage(ctx, assembledMsg);
} else { } else {
//first incomplete message //first incomplete message
fragments.put(streamIdentifier, byteBuf); fragments.put(streamIdentifier, byteBuf);
} }
} }
protected void fireAssembledMessage(ChannelHandlerContext ctx, SctpMessage assembledMsg) { private void handleAssembledMessage(ChannelHandlerContext ctx, SctpMessage assembledMsg) {
ctx.nextInboundMessageBuffer().add(assembledMsg); ctx.nextInboundMessageBuffer().add(assembledMsg);
ctx.fireInboundBufferUpdated(); assembled = true;
} }
} }