From 6491f359c77f358ceb408b0bcbe30706404a99b4 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Tue, 2 Apr 2019 20:51:11 +0200 Subject: [PATCH] Http2FrameLogger should not extend ChannelHandlerAdapter (#9002) Motivation: For what-ever reason Http2FrameLogger did extend ChannelHandlerAdapter but not override any of its methods. We should not extend it at all as it is not a ChannelHandler. Modifications: Remove extends Result: Less confusing / more correct / clear code. --- .../java/io/netty/handler/codec/http2/Http2FrameLogger.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java index 5908c9fd9e..4d22ea6aed 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java @@ -17,7 +17,6 @@ package io.netty.handler.codec.http2; import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBufUtil; -import io.netty.channel.ChannelHandlerAdapter; import io.netty.channel.ChannelHandlerContext; import io.netty.handler.logging.LogLevel; import io.netty.util.internal.UnstableApi; @@ -31,7 +30,7 @@ import static java.util.Objects.requireNonNull; * Logs HTTP2 frames for debugging purposes. */ @UnstableApi -public class Http2FrameLogger extends ChannelHandlerAdapter { +public class Http2FrameLogger { public enum Direction { INBOUND,