andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix resource leaks in StompSubframeAggregatorTest

Browse Source
This commit is contained in:
Trustin Lee 2014-08-05 18:11:45 -07:00
parent 168e81e9cd
commit 653262d2af
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompSubframeAggregatorTest.java
View File

@ -44,8 +44,10 @@ public class StompSubframeAggregatorTest {
ByteBuf incoming = Unpooled.buffer(); ByteBuf incoming = Unpooled.buffer();
incoming.writeBytes(StompTestConstants.CONNECT_FRAME.getBytes()); incoming.writeBytes(StompTestConstants.CONNECT_FRAME.getBytes());
channel.writeInbound(incoming); channel.writeInbound(incoming);
StompHeadersSubframe frame = channel.readInbound(); StompHeadersSubframe frame = channel.readInbound();
Assert.assertTrue(frame instanceof StompFrame); Assert.assertTrue(frame instanceof StompFrame);
Assert.assertNull(channel.readInbound()); Assert.assertNull(channel.readInbound());
} }
@ -54,10 +56,13 @@ public class StompSubframeAggregatorTest {
ByteBuf incoming = Unpooled.buffer(); ByteBuf incoming = Unpooled.buffer();
incoming.writeBytes(StompTestConstants.SEND_FRAME_2.getBytes()); incoming.writeBytes(StompTestConstants.SEND_FRAME_2.getBytes());
channel.writeInbound(incoming); channel.writeInbound(incoming);
StompFrame frame = channel.readInbound(); StompFrame frame = channel.readInbound();
Assert.assertNotNull(frame); Assert.assertNotNull(frame);
Assert.assertEquals(StompCommand.SEND, frame.command()); Assert.assertEquals(StompCommand.SEND, frame.command());
Assert.assertEquals("hello, queue a!!!", frame.content().toString(CharsetUtil.UTF_8)); Assert.assertEquals("hello, queue a!!!", frame.content().toString(CharsetUtil.UTF_8));
frame.release();
Assert.assertNull(channel.readInbound()); Assert.assertNull(channel.readInbound());
} }
@ -68,9 +73,12 @@ public class StompSubframeAggregatorTest {
ByteBuf incoming = Unpooled.buffer(); ByteBuf incoming = Unpooled.buffer();
incoming.writeBytes(StompTestConstants.SEND_FRAME_2.getBytes()); incoming.writeBytes(StompTestConstants.SEND_FRAME_2.getBytes());
channel.writeInbound(incoming); channel.writeInbound(incoming);
StompFrame frame = channel.readInbound(); StompFrame frame = channel.readInbound();
Assert.assertNotNull(frame); Assert.assertNotNull(frame);
Assert.assertEquals(StompCommand.SEND, frame.command()); Assert.assertEquals(StompCommand.SEND, frame.command());
frame.release();
Assert.assertNull(channel.readInbound()); Assert.assertNull(channel.readInbound());
} }
@ -81,12 +89,19 @@ public class StompSubframeAggregatorTest {
incoming.writeBytes(StompTestConstants.CONNECTED_FRAME.getBytes()); incoming.writeBytes(StompTestConstants.CONNECTED_FRAME.getBytes());
channel.writeInbound(incoming); channel.writeInbound(incoming);
channel.writeInbound(Unpooled.wrappedBuffer(StompTestConstants.SEND_FRAME_1.getBytes())); channel.writeInbound(Unpooled.wrappedBuffer(StompTestConstants.SEND_FRAME_1.getBytes()));
StompFrame frame = channel.readInbound(); StompFrame frame = channel.readInbound();
Assert.assertEquals(StompCommand.CONNECT, frame.command()); Assert.assertEquals(StompCommand.CONNECT, frame.command());
frame.release();
frame = channel.readInbound(); frame = channel.readInbound();
Assert.assertEquals(StompCommand.CONNECTED, frame.command()); Assert.assertEquals(StompCommand.CONNECTED, frame.command());
frame.release();
frame = channel.readInbound(); frame = channel.readInbound();
Assert.assertEquals(StompCommand.SEND, frame.command()); Assert.assertEquals(StompCommand.SEND, frame.command());
frame.release();
Assert.assertNull(channel.readInbound()); Assert.assertNull(channel.readInbound());
} }