andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* Better documentation for developers

Browse Source 
* Fixed a bug where a channelOpen event is swallowed
This commit is contained in:
Trustin Lee 2009-12-17 10:19:09 +00:00
parent 3fcfc910e1
commit 65634bda11
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/org/jboss/netty/handler/timeout/IdleStateHandler.java
View File

@ -202,7 +202,9 @@ public class IdleStateHandler extends SimpleChannelUpstreamHandler
public void beforeAdd(ChannelHandlerContext ctx) throws Exception { public void beforeAdd(ChannelHandlerContext ctx) throws Exception {
if (ctx.getPipeline().isAttached()) { if (ctx.getPipeline().isAttached()) {
// channelOpen() has been called already - initialize here instead. // channelOpen event has been fired already, which means
// this.channelOpen() will not be invoked.
// We have to initialize here instead.
initialize(ctx); initialize(ctx);
} }
} }
@ -222,7 +224,11 @@ public class IdleStateHandler extends SimpleChannelUpstreamHandler
@Override @Override
public void channelOpen(ChannelHandlerContext ctx, ChannelStateEvent e) public void channelOpen(ChannelHandlerContext ctx, ChannelStateEvent e)
throws Exception { throws Exception {
// This method will be invoked only if this handler was added
// before channelOpen event is fired. If a user adds this handler
// after the channelOpen event, initialize() will be called by beforeAdd().
initialize(ctx); initialize(ctx);
ctx.sendUpstream(e);
} }
@Override @Override

7
src/main/java/org/jboss/netty/handler/timeout/ReadTimeoutHandler.java
View File

@ -121,7 +121,9 @@ public class ReadTimeoutHandler extends SimpleChannelUpstreamHandler
public void beforeAdd(ChannelHandlerContext ctx) throws Exception { public void beforeAdd(ChannelHandlerContext ctx) throws Exception {
if (ctx.getPipeline().isAttached()) { if (ctx.getPipeline().isAttached()) {
// channelOpen() has been called already - initialize here instead. // channelOpen event has been fired already, which means
// this.channelOpen() will not be invoked.
// We have to initialize here instead.
initialize(ctx); initialize(ctx);
} }
} }
@ -141,6 +143,9 @@ public class ReadTimeoutHandler extends SimpleChannelUpstreamHandler
@Override @Override
public void channelOpen(ChannelHandlerContext ctx, ChannelStateEvent e) public void channelOpen(ChannelHandlerContext ctx, ChannelStateEvent e)
throws Exception { throws Exception {
// This method will be invoked only if this handler was added
// before channelOpen event is fired. If a user adds this handler
// after the channelOpen event, initialize() will be called by beforeAdd().
initialize(ctx); initialize(ctx);
ctx.sendUpstream(e); ctx.sendUpstream(e);
} }