andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[codec-memcache] Avoid NPE on channelInactive.

Browse Source 
Motivation:
When no currentMessage has been set and the channel is inactive, a NPE is raised.

Modification:
Make sure that a currentMessage is available before checking the extras.

Result:
No more NPE raised potentially.
This commit is contained in:
Michael Nitschinger 2014-04-23 11:38:55 +02:00
parent 8fd2f1c880
commit 65ee10fbd0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/AbstractBinaryMemcacheDecoder.java
View File

@ -201,7 +201,7 @@ public abstract class AbstractBinaryMemcacheDecoder<M extends BinaryMemcacheMess
public void channelInactive(ChannelHandlerContext ctx) throws Exception { public void channelInactive(ChannelHandlerContext ctx) throws Exception {
super.channelInactive(ctx); super.channelInactive(ctx);
if (currentMessage.getExtras() != null) { if (currentMessage != null && currentMessage.getExtras() != null) {
currentMessage.getExtras().release(); currentMessage.getExtras().release();
} }