From 694eab76eb8c0ee365a3c016680c10bfb8df761e Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Wed, 29 Apr 2015 11:10:36 -0700 Subject: [PATCH] HTTP/2 Warnings Cleanup Motiviation: There are a few spots in the HTTP/2 codec where warnings were generated and can be avoided. Modifications: Clean up the cause of the warnings. Result: Less warnings. --- .../io/netty/handler/codec/http2/DefaultHttp2Connection.java | 3 +-- .../io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java index 8cc03183ea..aadb93fe04 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java @@ -1177,13 +1177,12 @@ public class DefaultHttp2Connection implements Http2Connection { /** * A registry of all stream property keys known by this connection. */ - private class PropertyKeyRegistry { + private final class PropertyKeyRegistry { final List keys = new ArrayList(4); /** * Registers a new property key. */ - @SuppressWarnings("unchecked") DefaultPropertyKey newKey() { DefaultPropertyKey key = new DefaultPropertyKey(keys.size()); keys.add(key); diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java index 2ace1cfa25..f55030e70b 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java @@ -24,13 +24,11 @@ import static io.netty.handler.codec.http2.Http2FrameTypes.SETTINGS; import static io.netty.util.internal.ObjectUtil.checkNotNull; import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBufUtil; -import io.netty.buffer.Unpooled; import io.netty.channel.ChannelHandlerContext; import io.netty.handler.codec.base64.Base64; import io.netty.handler.codec.http.FullHttpRequest; import io.netty.handler.codec.http.FullHttpResponse; import io.netty.handler.codec.http.HttpServerUpgradeHandler; -import io.netty.util.ByteString; import io.netty.util.CharsetUtil; import java.nio.CharBuffer;