andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2684] EpollSocketChannel gathering writes should take fast-path if possible

Browse Source 
Motivation:

In EpollSocketchannel.writeBytesMultiple(...) we loop over all buffers to see if we need to adjust the readerIndex for incomplete writes. We can skip this if we know that everything was written (a.k.a complete write).

Modification:

Use fast-path if all bytes are written and so no need to loop over buffers

Result:

Fast write path for the average use.
This commit is contained in:
Norman Maurer 2014-07-21 06:43:49 +02:00
parent 9939c00541
commit 695fbc9140
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java
View File

@ -162,7 +162,13 @@ public final class EpollSocketChannel extends AbstractEpollChannel implements So
expectedWrittenBytes -= localWrittenBytes; expectedWrittenBytes -= localWrittenBytes;
writtenBytes += localWrittenBytes; writtenBytes += localWrittenBytes;
while (offset < end && localWrittenBytes > 0) { if (expectedWrittenBytes == 0) {
// Written everything, just break out here (fast-path)
done = true;
break loop;
}
do {
AddressEntry address = addresses[offset]; AddressEntry address = addresses[offset];
int readerIndex = address.readerIndex; int readerIndex = address.readerIndex;
int bytes = address.writerIndex - readerIndex; int bytes = address.writerIndex - readerIndex;
@ -175,12 +181,7 @@ public final class EpollSocketChannel extends AbstractEpollChannel implements So
addressCnt--; addressCnt--;
localWrittenBytes -= bytes; localWrittenBytes -= bytes;
} }
} } while (offset < end && localWrittenBytes > 0);
if (expectedWrittenBytes == 0) {
done = true;
break;
}
} }
} }
@ -207,8 +208,12 @@ public final class EpollSocketChannel extends AbstractEpollChannel implements So
} }
expectedWrittenBytes -= localWrittenBytes; expectedWrittenBytes -= localWrittenBytes;
writtenBytes += localWrittenBytes; writtenBytes += localWrittenBytes;
if (expectedWrittenBytes == 0) {
while (offset < end && localWrittenBytes > 0) { // Written everything, just break out here (fast-path)
done = true;
break loop;
}
do {
ByteBuffer buffer = nioBuffers[offset]; ByteBuffer buffer = nioBuffers[offset];
int pos = buffer.position(); int pos = buffer.position();
int bytes = buffer.limit() - pos; int bytes = buffer.limit() - pos;
@ -221,12 +226,7 @@ public final class EpollSocketChannel extends AbstractEpollChannel implements So
nioBufferCnt--; nioBufferCnt--;
localWrittenBytes -= bytes; localWrittenBytes -= bytes;
} }
} } while (offset < end && localWrittenBytes > 0);
if (expectedWrittenBytes == 0) {
done = true;
break;
}
} }
} }
updateOutboundBuffer(in, writtenBytes, msgCount, done); updateOutboundBuffer(in, writtenBytes, msgCount, done);