From 698f8d54eb909f820bed6166ce8db0863b6d68f9 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Tue, 27 Oct 2009 07:22:33 +0000 Subject: [PATCH] Applied the same fix for 'too many open files' to NioDatagramWorker --- .../channel/socket/nio/NioDatagramWorker.java | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorker.java b/src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorker.java index 50610930ab..4dffe82010 100644 --- a/src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorker.java +++ b/src/main/java/org/jboss/netty/channel/socket/nio/NioDatagramWorker.java @@ -125,6 +125,8 @@ class NioDatagramWorker implements Runnable { */ private final Queue writeTaskQueue = new LinkedTransferQueue(); + private volatile int cancelledKeys; + /** * Sole constructor. * @@ -250,6 +252,7 @@ class NioDatagramWorker implements Runnable { selector.wakeup(); } + cancelledKeys = 0; processRegisterTaskQueue(); processWriteTaskQueue(); processSelectedKeys(selector.selectedKeys()); @@ -647,14 +650,37 @@ class NioDatagramWorker implements Runnable { // Otherwise DatagramChannel.register() in RegisterTask can be called // after cancel(), but before close(), resulting in the infinite // Selector loop that refuses to shut down due to the dangling keys. + boolean cancelled = false; synchronized (channel.interestOpsLock) { SelectionKey key = channel.getDatagramChannel().keyFor(selector); if (key != null) { key.cancel(); + cancelled = true; } channel.getDatagramChannel().close(); } + if (cancelled) { + int cancelledKeys = ++ worker.cancelledKeys; + if (cancelledKeys >= 128) { // FIXME hardcoded value + worker.cancelledKeys = 0; + // Reclaim the associated file descriptors immediately. + // Otherwise the process will experience sudden spike + // in the number of open files, with high chance of getting + // the 'too many open files' error. + if (Thread.currentThread() == worker.thread) { + selector.selectNow(); + if (worker.wakenUp.get()) { + selector.wakeup(); + } + } else { + if (worker.wakenUp.compareAndSet(false, true)) { + selector.wakeup(); + } + } + } + } + if (channel.setClosed()) { future.setSuccess(); if (connected) {