andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Complete todo in SelfSignedCertificate (#9720)

Browse Source 
Motivation:

Easier to debug SelfSignedCertificate failures.

Modifications:

Add first throwable as suppressed to thrown exception.

Result:

Less technical debt.
This commit is contained in:
Johno Crawford 2019-10-28 14:47:00 +01:00 committed by Norman Maurer
parent 404008decf
commit 6ad59d14d7
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java
View File

@ -21,6 +21,7 @@ import io.netty.buffer.Unpooled;
import io.netty.handler.codec.base64.Base64; import io.netty.handler.codec.base64.Base64;
import io.netty.util.CharsetUtil; import io.netty.util.CharsetUtil;
import io.netty.util.internal.SystemPropertyUtil; import io.netty.util.internal.SystemPropertyUtil;
import io.netty.util.internal.ThrowableUtil;
import io.netty.util.internal.logging.InternalLogger; import io.netty.util.internal.logging.InternalLogger;
import io.netty.util.internal.logging.InternalLoggerFactory; import io.netty.util.internal.logging.InternalLoggerFactory;
@ -162,10 +163,11 @@ public final class SelfSignedCertificate {
paths = BouncyCastleSelfSignedCertGenerator.generate(fqdn, keypair, random, notBefore, notAfter); paths = BouncyCastleSelfSignedCertGenerator.generate(fqdn, keypair, random, notBefore, notAfter);
} catch (Throwable t2) { } catch (Throwable t2) {
logger.debug("Failed to generate a self-signed X.509 certificate using Bouncy Castle:", t2); logger.debug("Failed to generate a self-signed X.509 certificate using Bouncy Castle:", t2);
throw new CertificateException( final CertificateException certificateException = new CertificateException(
"No provider succeeded to generate a self-signed certificate. " + "No provider succeeded to generate a self-signed certificate. " +
"See debug log for the root cause.", t2); "See debug log for the root cause.", t2);
// TODO: consider using Java 7 addSuppressed to append t ThrowableUtil.addSuppressed(certificateException, t);
throw certificateException;
} }
} }