andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix JVM segfault during JNI call. Part of [#2647]

Browse Source 
Motivation:
Currently when Native.writev(...) is used it is possible to see a JVM segfault because the offset is updated to early.

Modification:
Only update the offset once it is safe to do so.

Result:
No more segfault
This commit is contained in:
Norman Maurer 2014-07-09 13:34:15 +02:00
parent 578068c7e6
commit 6b71089373
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
transport-native-epoll/src/main/c/io_netty_channel_epoll_Native.c
View File

@ -761,8 +761,6 @@ JNIEXPORT jlong JNICALL Java_io_netty_channel_epoll_Native_writev(JNIEnv * env,
} }
w += res; w += res;
offset += loop;
length -= loop;
// update the position of the written buffers // update the position of the written buffers
int written = res; int written = res;
@ -791,6 +789,8 @@ JNIEXPORT jlong JNICALL Java_io_netty_channel_epoll_Native_writev(JNIEnv * env,
} }
} }
offset += loop;
length -= loop;
} }
return w; return w;
} }