andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't log with warn level in the DnsNameResolver in most cases (#10225)

Browse Source 
Motivation:

We should only log with warn level if something really critical happens as otherwise we may spam logs and confuse the user.

Modifications:

- Change log level to debug for most cases

Result:

Less noisy logging
This commit is contained in:
Norman Maurer 2020-04-29 08:00:14 +02:00 committed by GitHub
parent 387e451c82
commit 6cd193e83f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
View File

@ -34,6 +34,7 @@ import io.netty.channel.socket.DatagramChannel;
import io.netty.channel.socket.DatagramPacket; import io.netty.channel.socket.DatagramPacket;
import io.netty.channel.socket.InternetProtocolFamily; import io.netty.channel.socket.InternetProtocolFamily;
import io.netty.channel.socket.SocketChannel; import io.netty.channel.socket.SocketChannel;
import io.netty.handler.codec.CorruptedFrameException;
import io.netty.handler.codec.dns.DatagramDnsQueryEncoder; import io.netty.handler.codec.dns.DatagramDnsQueryEncoder;
import io.netty.handler.codec.dns.DatagramDnsResponse; import io.netty.handler.codec.dns.DatagramDnsResponse;
import io.netty.handler.codec.dns.DatagramDnsResponseDecoder; import io.netty.handler.codec.dns.DatagramDnsResponseDecoder;
@ -1215,7 +1216,7 @@ public class DnsNameResolver extends InetNameResolver {
final DnsQueryContext qCtx = queryContextManager.get(res.sender(), queryId); final DnsQueryContext qCtx = queryContextManager.get(res.sender(), queryId);
if (qCtx == null) { if (qCtx == null) {
logger.warn("{} Received a DNS response with an unknown ID: {}", ch, queryId); logger.debug("Received a DNS response with an unknown ID: UDP [{}: {}]", ch, queryId);
res.release(); res.release();
return; return;
} }
@ -1236,7 +1237,7 @@ public class DnsNameResolver extends InetNameResolver {
public void operationComplete(ChannelFuture future) { public void operationComplete(ChannelFuture future) {
if (!future.isSuccess()) { if (!future.isSuccess()) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("{} Unable to fallback to TCP [{}]", queryId, future.cause()); logger.debug("Unable to fallback to TCP [{}]", queryId, future.cause());
} }
// TCP fallback failed, just use the truncated response. // TCP fallback failed, just use the truncated response.
@ -1272,8 +1273,8 @@ public class DnsNameResolver extends InetNameResolver {
response)); response));
} else { } else {
response.release(); response.release();
tcpCtx.tryFailure("Received TCP response with unexpected ID", null, false); tcpCtx.tryFailure("Received TCP DNS response with unexpected ID", null, false);
logger.warn("{} Received a DNS response with an unexpected ID: {}", logger.debug("Received a DNS response with an unexpected ID: TCP [{}: {}]",
channel, queryId); channel, queryId);
} }
} }
@ -1317,7 +1318,11 @@ public class DnsNameResolver extends InetNameResolver {
@Override @Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
logger.warn("{} Unexpected exception: ", ctx.channel(), cause); if (cause instanceof CorruptedFrameException) {
logger.debug("Unable to decode DNS response: UDP [{}]", ctx.channel(), cause);
} else {
logger.warn("Unexpected exception: UDP [{}]", ctx.channel(), cause);
}
} }
} }