andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add FIXME

Browse Source
This commit is contained in:
Trustin Lee 2012-05-28 05:20:32 -07:00
parent e48281471b
commit 6d39c342b6
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java
View File

@ -160,6 +160,10 @@ public class NioSocketChannel extends AbstractNioStreamChannel implements io.net
@Override @Override
protected int doWriteBytes(ChannelBuffer buf, boolean lastSpin) throws Exception { protected int doWriteBytes(ChannelBuffer buf, boolean lastSpin) throws Exception {
final int expectedWrittenBytes = buf.readableBytes(); final int expectedWrittenBytes = buf.readableBytes();
// FIXME: This is not as efficient as Netty 3's SendBufferPool if heap buffer is used
// because of potentially unwanted repetitive memory copy in case of
// a slow connection or a large output buffer that triggers OP_WRITE.
final int writtenBytes = buf.readBytes(javaChannel(), expectedWrittenBytes); final int writtenBytes = buf.readBytes(javaChannel(), expectedWrittenBytes);
final SelectionKey key = selectionKey(); final SelectionKey key = selectionKey();