From 6fb5b14ef59b2188174d1286730bd818cbb99bb6 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 30 May 2016 11:27:20 +0200 Subject: [PATCH] [#5308] Ensure InetSocketAddressResolver.close() will close the wrapped NameResolver. Motivation: InetSocketAddressResolver.close() must call close() on the wrapped NameResolver. Modifications: Correctly call close() on wrapped NameResolver and added test. Result: close() is correctly propergated to the wrapped resolver. --- .../resolver/InetSocketAddressResolver.java | 5 +++ .../InetSocketAddressResolverTest.java | 36 +++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 resolver/src/test/java/io/netty/resolver/InetSocketAddressResolverTest.java diff --git a/resolver/src/main/java/io/netty/resolver/InetSocketAddressResolver.java b/resolver/src/main/java/io/netty/resolver/InetSocketAddressResolver.java index 80d4c51f81..a710914385 100644 --- a/resolver/src/main/java/io/netty/resolver/InetSocketAddressResolver.java +++ b/resolver/src/main/java/io/netty/resolver/InetSocketAddressResolver.java @@ -88,4 +88,9 @@ public class InetSocketAddressResolver extends AbstractAddressResolver nameResolver = mock(NameResolver.class); + InetSocketAddressResolver resolver = new InetSocketAddressResolver( + ImmediateEventExecutor.INSTANCE, nameResolver); + resolver.close(); + verify(nameResolver, times(1)).close(); + } +}