andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#7695 no need to manually release chunk during upload (#7696)

Browse Source 
Motivation:

After #7527 fix there is no need to manually release chunks (HttpData) during file upload as they will be released on HttpPostRequestDecoder.destroy().

Modification:

HttpUploadServer example doesn't release chunks manually (doesn't call data.release()).

Result:
Fixes #7695 and #7689
This commit is contained in:
Dmitriy Dumanskiy 2018-11-02 09:12:10 +02:00 committed by Norman Maurer
parent bde2865ef8
commit 6fbb12e2c2
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
example/src/main/java/io/netty/example/http/upload/HttpUploadServerHandler.java
View File

@ -225,12 +225,8 @@ public class HttpUploadServerHandler extends SimpleChannelInboundHandler<HttpObj
logger.info(" 100% (FinalSize: " + partialContent.length() + ")"); logger.info(" 100% (FinalSize: " + partialContent.length() + ")");
partialContent = null; partialContent = null;
} }
try { // new value
// new value writeHttpData(data);
writeHttpData(data);
} finally {
data.release();
}
} }
} }
// Check partial decoding for a FileUpload // Check partial decoding for a FileUpload