andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Correctly reset MessageDigest before reusing it.

Browse Source 
Motivation:

I missed to reset the MessageDigest before reusing it. This bug was introduced by 79634e661b000b5f229fdde20e44fdeab15c5ae2.

Modifications:

Call reset() on the MessageDigest.

Result:

Correctly reset MessageDigest before re-using
This commit is contained in:
Norman Maurer 2016-01-04 14:29:21 +01:00
parent ec8c56915b
commit 705db6cf2a
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketUtil.java
View File

@ -63,7 +63,7 @@ final class WebSocketUtil {
*/
static byte[] md5(byte[] data) {
// TODO(normanmaurer): Create md5 method that not need MessageDigest.
return MD5.get().digest(data);
return digest(MD5, data);
}
/**
@ -74,7 +74,13 @@ final class WebSocketUtil {
*/
static byte[] sha1(byte[] data) {
// TODO(normanmaurer): Create sha1 method that not need MessageDigest.
return SHA1.get().digest(data);
return digest(SHA1, data);
}
private static byte[] digest(FastThreadLocal<MessageDigest> digestFastThreadLocal, byte[] data) {
MessageDigest digest = digestFastThreadLocal.get();
digest.reset();
return digest.digest(data);
}
/**