andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add comment about why we need to count the depth of the stack in AioCompletionHandler

Browse Source
This commit is contained in:
Trustin Lee 2013-02-26 11:28:49 -08:00
parent 0317baa10d
commit 709f2dfb33
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
transport/src/main/java/io/netty/channel/aio/AioCompletionHandler.java
View File

@ -35,6 +35,11 @@ public abstract class AioCompletionHandler<V, A extends Channel> implements Comp
*/ */
protected abstract void failed0(Throwable exc, A channel); protected abstract void failed0(Throwable exc, A channel);
// According to JDK AIO documentation, the ExecutorService a user specified must not call the Runnable given by
// JDK AIO implementation directly. However, we violates that rull by calling Runnable.run() directly for
// optimization purposes, and it can result in infinite recursion in combination with the fact that the JDK AIO
// implementation often makes recursive invocations. Therefore, we must make sure we don't go too deep in the
// stack.
private static final int MAX_STACK_DEPTH = 8; private static final int MAX_STACK_DEPTH = 8;
private static final ThreadLocal<Integer> STACK_DEPTH = new ThreadLocal<Integer>() { private static final ThreadLocal<Integer> STACK_DEPTH = new ThreadLocal<Integer>() {
@Override @Override