andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ensure the correct wrapped buffer is released in AbstractPooledDerivedByteBuf.deallocate()

Browse Source 
Motivation:

We need to first store a reference to the wrapped buffer before recycle the AbstractPooledDerivedByteBuf instance. This is needed as otherwise it is possible that the same AbstractPooledDerivedByteBuf is again obtained and init(...) is called before we actually have a chance to call release(). This leads to call release() on the wrong buffer.

Modifications:

Store a reference to the wrapped buffer before call recycle and call release on the previous stored reference.

Result:

Always release the correct wrapped buffer when deallocate the AbstractPooledDerivedByteBuf.
This commit is contained in:
Norman Maurer 2016-06-03 15:21:28 +02:00
parent ee5969edfd
commit 7137d22994
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
buffer/src/main/java/io/netty/buffer/AbstractPooledDerivedByteBuf.java
View File

@ -66,8 +66,12 @@ abstract class AbstractPooledDerivedByteBuf<T> extends AbstractReferenceCountedB
@Override
protected final void deallocate() {
// We need to first store a reference to the wrapped buffer before recycle this instance. This is needed as
// otherwise it is possible that the same AbstractPooledDerivedByteBuf is again obtained and init(...) is
// called before we actually have a chance to call release(). This leads to call release() on the wrong buffer.
ByteBuf wrapped = unwrap();
recyclerHandle.recycle(this);
unwrap().release();
wrapped.release();
}
@Override