andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1729] Let StringEncoder extend MessageToMessageEncoder and so safe a memory copy

Browse Source
This commit is contained in:
Norman Maurer 2013-08-11 21:24:02 +02:00
parent 9a88c50ffb
commit 73755d1233
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
codec/src/main/java/io/netty/handler/codec/string/StringEncoder.java
View File

@ -21,9 +21,10 @@ import io.netty.channel.ChannelHandler.Sharable;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPipeline; import io.netty.channel.ChannelPipeline;
import io.netty.handler.codec.LineBasedFrameDecoder; import io.netty.handler.codec.LineBasedFrameDecoder;
import io.netty.handler.codec.MessageToByteEncoder; import io.netty.handler.codec.MessageToMessageEncoder;
import java.nio.charset.Charset; import java.nio.charset.Charset;
import java.util.List;
/** /**
* Encodes the requested {@link String} into a {@link ByteBuf}. * Encodes the requested {@link String} into a {@link ByteBuf}.
@ -47,7 +48,7 @@ import java.nio.charset.Charset;
* </pre> * </pre>
*/ */
@Sharable @Sharable
public class StringEncoder extends MessageToByteEncoder<CharSequence> { public class StringEncoder extends MessageToMessageEncoder<CharSequence> {
// TODO Use CharsetEncoder instead. // TODO Use CharsetEncoder instead.
private final Charset charset; private final Charset charset;
@ -70,16 +71,11 @@ public class StringEncoder extends MessageToByteEncoder<CharSequence> {
} }
@Override @Override
protected void encode(ChannelHandlerContext ctx, CharSequence msg, ByteBuf out) throws Exception { protected void encode(ChannelHandlerContext ctx, CharSequence msg, List<Object> out) throws Exception {
if (msg.length() == 0) { if (msg.length() == 0) {
return; return;
} }
ByteBuf encoded = Unpooled.copiedBuffer(msg, charset); out.add(Unpooled.copiedBuffer(msg, charset));
try {
out.writeBytes(encoded);
} finally {
encoded.release();
}
} }
} }