diff --git a/codec-redis/src/main/java/io/netty/handler/codec/redis/RedisDecoder.java b/codec-redis/src/main/java/io/netty/handler/codec/redis/RedisDecoder.java index d0104cc25f..4c70444efa 100644 --- a/codec-redis/src/main/java/io/netty/handler/codec/redis/RedisDecoder.java +++ b/codec-redis/src/main/java/io/netty/handler/codec/redis/RedisDecoder.java @@ -201,7 +201,7 @@ public final class RedisDecoder extends ByteToMessageDecoder { // ${expectedBulkLength}\r\n {data...}\r\n private boolean decodeBulkStringContent(ByteBuf in, List out) throws Exception { final int readableBytes = in.readableBytes(); - if (readableBytes == 0) { + if (readableBytes == 0 || remainingBulkLength == 0 && readableBytes < RedisConstants.EOL_LENGTH) { return false; } diff --git a/codec-redis/src/test/java/io/netty/handler/codec/redis/RedisDecoderTest.java b/codec-redis/src/test/java/io/netty/handler/codec/redis/RedisDecoderTest.java index d7e7a40858..d7738aa2c7 100644 --- a/codec-redis/src/test/java/io/netty/handler/codec/redis/RedisDecoderTest.java +++ b/codec-redis/src/test/java/io/netty/handler/codec/redis/RedisDecoderTest.java @@ -27,9 +27,15 @@ import org.junit.Test; import java.util.List; -import static io.netty.handler.codec.redis.RedisCodecTestUtil.*; -import static org.hamcrest.CoreMatchers.*; -import static org.junit.Assert.*; +import static io.netty.handler.codec.redis.RedisCodecTestUtil.byteBufOf; +import static io.netty.handler.codec.redis.RedisCodecTestUtil.bytesOf; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.instanceOf; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; /** * Verifies the correct functionality of the {@link RedisDecoder} and {@link RedisArrayAggregator}. @@ -51,6 +57,16 @@ public class RedisDecoderTest { assertFalse(channel.finish()); } + @Test + public void splitEOLDoesNotInfiniteLoop() throws Exception { + assertFalse(channel.writeInbound(byteBufOf("$6\r\nfoobar\r"))); + assertTrue(channel.writeInbound(byteBufOf("\n"))); + + RedisMessage msg = channel.readInbound(); + assertTrue(msg instanceof FullBulkStringRedisMessage); + ReferenceCountUtil.release(msg); + } + @Test public void shouldDecodeSimpleString() { assertFalse(channel.writeInbound(byteBufOf("+")));