Correctly implement CharSequenceValueConvert.convertTimeMillis

Motivation:

If you pass the output of CharSequenceValueConvert.convertToTimeMillis to convertTimeMillis it will throw a ParseException.

Modifications:

- Correctly implement CharSequenceValueConverter.convertTimeMillis
- Add unit-tests for CharSequenceValueConverter

Result:

Correctly convert timemillis.
This commit is contained in:
Norman Maurer 2018-02-15 09:03:14 +01:00
parent c1d0d88f0a
commit 756854e99a
2 changed files with 75 additions and 1 deletions

View File

@ -125,7 +125,7 @@ public class CharSequenceValueConverter implements ValueConverter<CharSequence>
@Override @Override
public CharSequence convertTimeMillis(long value) { public CharSequence convertTimeMillis(long value) {
return String.valueOf(value); return DateFormatter.format(new Date(value));
} }
@Override @Override

View File

@ -0,0 +1,74 @@
/*
* Copyright 2018 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License, version 2.0 (the
* "License"); you may not use this file except in compliance with the License. You may obtain a
* copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
package io.netty.handler.codec;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
public class CharSequenceValueConverterTest {
private final CharSequenceValueConverter converter = CharSequenceValueConverter.INSTANCE;
@Test
public void testBoolean() {
assertTrue(converter.convertToBoolean(converter.convertBoolean(true)));
assertFalse(converter.convertToBoolean(converter.convertBoolean(false)));
}
@Test
public void testByte() {
assertEquals(Byte.MAX_VALUE, converter.convertToByte(converter.convertByte(Byte.MAX_VALUE)));
}
@Test
public void testChar() {
assertEquals(Character.MAX_VALUE, converter.convertToChar(converter.convertChar(Character.MAX_VALUE)));
}
@Test
public void testDouble() {
assertEquals(Double.MAX_VALUE, converter.convertToDouble(converter.convertDouble(Double.MAX_VALUE)), 0);
}
@Test
public void testFloat() {
assertEquals(Float.MAX_VALUE, converter.convertToFloat(converter.convertFloat(Float.MAX_VALUE)), 0);
}
@Test
public void testInt() {
assertEquals(Integer.MAX_VALUE, converter.convertToInt(converter.convertInt(Integer.MAX_VALUE)));
}
@Test
public void testShort() {
assertEquals(Short.MAX_VALUE, converter.convertToShort(converter.convertShort(Short.MAX_VALUE)));
}
@Test
public void testLong() {
assertEquals(Long.MAX_VALUE, converter.convertToLong(converter.convertLong(Long.MAX_VALUE)));
}
@Test
public void testTimeMillis() {
// Zero out the millis as this is what the convert is doing as well.
long millis = (System.currentTimeMillis() / 1000) * 1000;
assertEquals(millis, converter.convertToTimeMillis(converter.convertTimeMillis(millis)));
}
}