diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java index 26a41aad9c..ec05f5b0ac 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DefaultHttpDataFactory.java @@ -34,6 +34,7 @@ import java.util.concurrent.ConcurrentMap; * according to the constructor. */ public class DefaultHttpDataFactory implements HttpDataFactory { + /** * Proposed default MINSIZE as 16 KB. */ @@ -54,7 +55,7 @@ public class DefaultHttpDataFactory implements HttpDataFactory { private Charset charset = HttpConstants.DEFAULT_CHARSET; /** - * Keep all HttpDatas until cleanAllHttpDatas() is called. + * Keep all HttpDatas until cleanAllHttpData() is called. */ private final ConcurrentMap> requestFileDeleteMap = PlatformDependent.newConcurrentHashMap(); @@ -223,7 +224,7 @@ public class DefaultHttpDataFactory implements HttpDataFactory { } @Override - public void cleanRequestHttpDatas(HttpRequest request) { + public void cleanRequestHttpData(HttpRequest request) { List fileToDelete = requestFileDeleteMap.remove(request); if (fileToDelete != null) { for (HttpData data: fileToDelete) { @@ -234,7 +235,7 @@ public class DefaultHttpDataFactory implements HttpDataFactory { } @Override - public void cleanAllHttpDatas() { + public void cleanAllHttpData() { for (HttpRequest request : requestFileDeleteMap.keySet()) { List fileToDelete = requestFileDeleteMap.get(request); if (fileToDelete != null) { diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpDataFactory.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpDataFactory.java index ab0305ecf2..dce42f7f1f 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpDataFactory.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpDataFactory.java @@ -23,6 +23,7 @@ import java.nio.charset.Charset; * Interface to enable creation of InterfaceHttpData objects */ public interface HttpDataFactory { + /** * To set a max size limitation on fields. Exceeding it will generate an ErrorDataDecoderException. * A value of -1 means no limitation (default). @@ -31,10 +32,10 @@ public interface HttpDataFactory { void setMaxLimit(long max); /** - * - * @param request associated request - * @return a new Attribute with no value - */ + * + * @param request associated request + * @return a new Attribute with no value + */ Attribute createAttribute(HttpRequest request, String name); /** @@ -64,10 +65,10 @@ public interface HttpDataFactory { * * @param request associated request */ - void cleanRequestHttpDatas(HttpRequest request); + void cleanRequestHttpData(HttpRequest request); /** * Remove all InterfaceHttpData from virtual File storage from clean list for all requests */ - void cleanAllHttpDatas(); + void cleanAllHttpData(); } diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index f8cbb216c2..a83da111b8 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java @@ -914,7 +914,7 @@ public class HttpPostMultipartRequestDecoder implements InterfaceHttpPostRequest public void cleanFiles() { checkDestroyed(); - factory.cleanRequestHttpDatas(request); + factory.cleanRequestHttpData(request); } /** diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java index bbc87ae57b..8fbbfb77a1 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java @@ -212,7 +212,7 @@ public class HttpPostRequestEncoder implements ChunkedInput { * Clean all HttpDatas (on Disk) for the current request. */ public void cleanFiles() { - factory.cleanRequestHttpDatas(request); + factory.cleanRequestHttpData(request); } /** diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java index 3bdc3e8574..6873dd9045 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java @@ -718,7 +718,7 @@ public class HttpPostStandardRequestDecoder implements InterfaceHttpPostRequestD public void cleanFiles() { checkDestroyed(); - factory.cleanRequestHttpDatas(request); + factory.cleanRequestHttpData(request); } /** diff --git a/example/src/main/java/io/netty/example/http/upload/HttpUploadClient.java b/example/src/main/java/io/netty/example/http/upload/HttpUploadClient.java index 4818476c75..1e75ddb6fc 100644 --- a/example/src/main/java/io/netty/example/http/upload/HttpUploadClient.java +++ b/example/src/main/java/io/netty/example/http/upload/HttpUploadClient.java @@ -130,14 +130,14 @@ public class HttpUploadClient { // Simple Get form: no factory used (not usable) List> headers = formGet(b, host, port, get, uriSimple); if (headers == null) { - factory.cleanAllHttpDatas(); + factory.cleanAllHttpData(); return; } // Simple Post form: factory used for big attributes List bodylist = formPost(b, host, port, uriSimple, file, factory, headers); if (bodylist == null) { - factory.cleanAllHttpDatas(); + factory.cleanAllHttpData(); return; } @@ -148,7 +148,7 @@ public class HttpUploadClient { group.shutdownGracefully(); // Really clean all temporary files if they still exist - factory.cleanAllHttpDatas(); + factory.cleanAllHttpData(); } }