andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make sure HttpVersion checks if the version string is not empty

Browse Source 
.. which was the behavior in 3.x.
This commit is contained in:
Trustin Lee 2013-10-17 20:26:51 +09:00
parent 9600318dc1
commit 762e40f357
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java
View File

@ -55,6 +55,11 @@ public class HttpVersion implements Comparable<HttpVersion> {
} }
text = text.trim(); text = text.trim();
if (text.isEmpty()) {
throw new IllegalArgumentException("text is empty");
}
// Try to match without convert to uppercase first as this is what 99% of all clients // Try to match without convert to uppercase first as this is what 99% of all clients
// will send anyway. Also there is a change to the RFC to make it clear that it is // will send anyway. Also there is a change to the RFC to make it clear that it is
// expected to be case-sensitive // expected to be case-sensitive
@ -65,7 +70,7 @@ public class HttpVersion implements Comparable<HttpVersion> {
// //
// TODO: Remove the uppercase conversion in 4.1.0 as the RFC state it must be HTTP (uppercase) // TODO: Remove the uppercase conversion in 4.1.0 as the RFC state it must be HTTP (uppercase)
// See https://github.com/netty/netty/issues/1682 // See https://github.com/netty/netty/issues/1682
//
HttpVersion version = version0(text); HttpVersion version = version0(text);
if (version == null) { if (version == null) {
text = text.toUpperCase(); text = text.toUpperCase();