andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Eliminate a redundant method call in HpackDynamicTable.add(...) (#10399)

Browse Source 
Motivation:

The result of `header.size()` is already cached in `headerSize`. There is no need to call it again actually.

Modification:

Replace the second `header.size()` with `headerSize` directly.

Result:

Improve performance slightly.
This commit is contained in:
feijermu 2020-07-13 23:34:29 +08:00 committed by GitHub
parent 5a372f0cb1
commit 77101ab8af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDynamicTable.java
View File

@ -109,7 +109,7 @@ final class HpackDynamicTable {
remove();
}
hpackHeaderFields[head++] = header;
size += header.size();
size += headerSize;
if (head == hpackHeaderFields.length) {
head = 0;
}

24
codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDynamicTableTest.java
View File

@ -103,4 +103,28 @@ public class HpackDynamicTableTest {
assertEquals(0, table.length());
assertEquals(0, table.size());
}
@Test
public void testAdd() {
HpackDynamicTable table = new HpackDynamicTable(100);
assertEquals(0, table.size());
HpackHeaderField entry1 = new HpackHeaderField("foo", "bar"); //size:3+3+32=38
HpackHeaderField entry2 = new HpackHeaderField("hello", "world");
table.add(entry1); //success
assertEquals(entry1.size(), table.size());
table.setCapacity(32); //entry1 is removed from table
assertEquals(0, table.size());
assertEquals(0, table.length());
table.add(entry1); //fail quietly
assertEquals(0, table.size());
assertEquals(0, table.length());
table.setCapacity(64);
table.add(entry1); //success
assertEquals(entry1.size(), table.size());
assertEquals(1, table.length());
table.add(entry2); //entry2 is added, but entry1 is removed from table
assertEquals(entry2.size(), table.size());
assertEquals(1, table.length());
assertEquals(entry2, table.getEntry(1));
}
}