andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Pre-increment leakCheckCnt to prevent false leak-detectation for very first time

Browse Source 
Motivation:
ResourceLeakDetector reports leak for first call to open(obj) as its leakCheckCnt starts with value 0 and increment subsequently. with value of leakCheckCnt =0, it always returns ResourceLeak. Our application calls ResourceLeakDetector.open(obj) to validate Leak and it fails at very first call even though there is no leak in application.

Modifications:
ResourceLeakDetector.leakCheckCnt value will not be 0 while deriving leak and it will not return incorrect value of ResourceLeak.

Result:
Fix false leak report on first call on ResourceLeakDetector.
This commit is contained in:
rdhabalia 2016-09-28 14:35:25 -07:00 committed by Norman Maurer
parent 149916d052
commit 789c9a53df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/src/main/java/io/netty/util/ResourceLeakDetector.java
View File

@ -221,7 +221,7 @@ public class ResourceLeakDetector<T> {
}
if (level.ordinal() < Level.PARANOID.ordinal()) {
if ((leakCheckCnt ++ & mask) == 0) {
if ((++ leakCheckCnt & mask) == 0) {
reportLeak(level);
return new DefaultResourceLeak(obj);
} else {