andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove Arrays.fill(..., null)

Browse Source 
.. because we can just set each element to null while looping
This commit is contained in:
Trustin Lee 2013-07-23 15:09:14 +09:00
parent a89b17fa94
commit 7903697c36
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java
View File

@ -30,7 +30,6 @@ import io.netty.util.internal.logging.InternalLoggerFactory;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.nio.channels.ClosedChannelException; import java.nio.channels.ClosedChannelException;
import java.util.Arrays;
import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
/** /**
@ -208,7 +207,9 @@ public final class ChannelOutboundBuffer {
for (int i = 0; i < unflushedCount; i ++) { for (int i = 0; i < unflushedCount; i ++) {
flushed[tail] = unflushed[i]; flushed[tail] = unflushed[i];
unflushed[i] = null;
flushedPromises[tail] = unflushedPromises[i]; flushedPromises[tail] = unflushedPromises[i];
unflushedPromises[i] = null;
flushedPendingSizes[tail] = unflushedPendingSizes[i]; flushedPendingSizes[tail] = unflushedPendingSizes[i];
flushedProgresses[tail] = 0; flushedProgresses[tail] = 0;
flushedTotals[tail] = unflushedTotals[i]; flushedTotals[tail] = unflushedTotals[i];
@ -225,8 +226,6 @@ public final class ChannelOutboundBuffer {
} }
} }
Arrays.fill(unflushed, 0, unflushedCount, null);
Arrays.fill(unflushedPromises, 0, unflushedCount, null);
this.unflushedCount = 0; this.unflushedCount = 0;
this.tail = tail; this.tail = tail;