andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2359] EpollSocketChannel.remoteAddress0() is always null on accepted EpollSocketChannels

Browse Source 
Motivation:
EpollSocketChannel.remoteAddress0() is always null on accepted EpollSocketChannels as we not set it excplicit.

Modifications:
Correctly retrieve the local and remote address when accept new channel and store it

Result:
EpollSocketchannel.remoteAddress0() and EpollSocketChannel.localAddress0() return correct addresses
This commit is contained in:
Norman Maurer 2014-04-04 15:22:06 +02:00
parent fdb1db90c4
commit 791c38befe
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannel.java
View File

@ -66,9 +66,13 @@ public final class EpollSocketChannel extends AbstractEpollChannel implements So
private volatile boolean inputShutdown; private volatile boolean inputShutdown;
private volatile boolean outputShutdown; private volatile boolean outputShutdown;
EpollSocketChannel(Channel parent, int fd) { EpollSocketChannel(Channel parent, int fd) throws IOException {
super(parent, fd, Native.EPOLLIN, true); super(parent, fd, Native.EPOLLIN, true);
config = new EpollSocketChannelConfig(this); config = new EpollSocketChannelConfig(this);
// Directly cache the remote and local addresses
// See https://github.com/netty/netty/issues/2359
remote = Native.remoteAddress(fd);
local = Native.localAddress(fd);
} }
public EpollSocketChannel() { public EpollSocketChannel() {