From 795a78cc89da0170f938fb0a705bd85af05a5e66 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Tue, 24 Jun 2014 16:40:44 +0900 Subject: [PATCH] Hide SocksMessage.encodeAsByteBuf() from public API It was an internal use only method which became public by a mistake during the review process. --- .../java/io/netty/handler/codec/socks/SocksAuthRequest.java | 2 +- .../java/io/netty/handler/codec/socks/SocksAuthResponse.java | 2 +- .../main/java/io/netty/handler/codec/socks/SocksCmdRequest.java | 2 +- .../java/io/netty/handler/codec/socks/SocksCmdResponse.java | 2 +- .../java/io/netty/handler/codec/socks/SocksInitRequest.java | 2 +- .../java/io/netty/handler/codec/socks/SocksInitResponse.java | 2 +- .../main/java/io/netty/handler/codec/socks/SocksMessage.java | 2 +- .../java/io/netty/handler/codec/socks/UnknownSocksRequest.java | 2 +- .../java/io/netty/handler/codec/socks/UnknownSocksResponse.java | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthRequest.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthRequest.java index 0bad2a85e4..6d55309854 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthRequest.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthRequest.java @@ -73,7 +73,7 @@ public final class SocksAuthRequest extends SocksRequest { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(SUBNEGOTIATION_VERSION.byteValue()); byteBuf.writeByte(username.length()); byteBuf.writeBytes(username.getBytes(CharsetUtil.US_ASCII)); diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthResponse.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthResponse.java index 5cacdde79e..42ec1aa6a4 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthResponse.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksAuthResponse.java @@ -45,7 +45,7 @@ public final class SocksAuthResponse extends SocksResponse { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(SUBNEGOTIATION_VERSION.byteValue()); byteBuf.writeByte(authStatus.byteValue()); } diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdRequest.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdRequest.java index dfcdad8768..9677e07dce 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdRequest.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdRequest.java @@ -109,7 +109,7 @@ public final class SocksCmdRequest extends SocksRequest { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(protocolVersion().byteValue()); byteBuf.writeByte(cmdType.byteValue()); byteBuf.writeByte(0x00); diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java index c918c3182a..35c7842c00 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCmdResponse.java @@ -144,7 +144,7 @@ public final class SocksCmdResponse extends SocksResponse { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(protocolVersion().byteValue()); byteBuf.writeByte(cmdStatus.byteValue()); byteBuf.writeByte(0x00); diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitRequest.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitRequest.java index 2299d2b63b..c4be4bcdc6 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitRequest.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitRequest.java @@ -47,7 +47,7 @@ public final class SocksInitRequest extends SocksRequest { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(protocolVersion().byteValue()); byteBuf.writeByte(authSchemes.size()); for (SocksAuthScheme authScheme : authSchemes) { diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitResponse.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitResponse.java index b4d90391fe..15b1b8bea4 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitResponse.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksInitResponse.java @@ -44,7 +44,7 @@ public final class SocksInitResponse extends SocksResponse { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { byteBuf.writeByte(protocolVersion().byteValue()); byteBuf.writeByte(authScheme.byteValue()); } diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksMessage.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksMessage.java index ba88e41b6f..68be6306a0 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksMessage.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/SocksMessage.java @@ -57,5 +57,5 @@ public abstract class SocksMessage { /** * Encode socks message into its byte representation and write it into byteBuf */ - public abstract void encodeAsByteBuf(ByteBuf byteBuf); + abstract void encodeAsByteBuf(ByteBuf byteBuf); } diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksRequest.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksRequest.java index e99687c562..7765d498f5 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksRequest.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksRequest.java @@ -31,7 +31,7 @@ public final class UnknownSocksRequest extends SocksRequest { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { // NOOP } } diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksResponse.java b/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksResponse.java index 9f4e5f80e7..83235665f8 100644 --- a/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksResponse.java +++ b/codec-socks/src/main/java/io/netty/handler/codec/socks/UnknownSocksResponse.java @@ -31,7 +31,7 @@ public final class UnknownSocksResponse extends SocksResponse { } @Override - public void encodeAsByteBuf(ByteBuf byteBuf) { + void encodeAsByteBuf(ByteBuf byteBuf) { // NOOP } }